Taro Logo

Does not understand UI Engineering

UI Engineer
Former Employee
Worked at Charles Schwab for 4 years
August 28, 2015
Austin, Texas
1.0
Doesn't RecommendPositive Outlook
Pros

Not many. Their lack of UI knowledge does not create much opportunity for constructive criticism. Schwab's focus is on a dated hierarchical culture before working as a team to create better technology.

Cons

They have adapted TypeScript and Angular as front end technology. On the surface, the code looks brilliant, well organized, and highly functional. As you peel back the layers, you see many anti-patterns, and a very unprofessional attitude among leads enforce these anti-patterns. Schwab has this hierarchy leadership culture that does not easily permit new knowledge and ideas, especially from contractors. It's a very dated mindset, whereas open source technology facilitates communal contributions.

TypeScript is used as an excuse not to learn Angular properly. Inheritance is strongly favored over composition, with deep layers of super classes. This creates, ironically, very tight coupling to dead code and unused functionality, so refactoring and cleanup is a major task that takes weeks.

A lot of money is wasted working in poor architecture.

Angular controllers are +10k lines.

Overuse of Angular logic in html (ng-if, ng-show, ng-init), which are well documented anti-patterns. They have no clue how to create and use directives properly to fix these issues.

Routes are used like services to reuse controllers, where services should be used. Hence the +10k lines in controllers. Whereas routes should be used for deep linking, and not necessarily for state management. They have to use variable swaps to keep data "organized". Very fragile code. They clearly do not understand modularization and separation of concerns.

Use of TypeScript causes memory leaks and fragile functionality, where if they learn Angular, this would not be an issue as much.

Worst of all, leadership blames "inexperienced" people for poorly written code and bugs, yet they approve every line committed via code reviews. They take no responsibility for work submitted. By this workflow, they should be accountable for everything. In other companies and industries, leadership takes full responsibility in a similar workflow. The lead architect and team leads facilitate this culture of non-collaboration, as if they will lose their job for fear of incompetence if they listen to other people objectively.

When presenting Angular Standards to leadership, you will hear excuses like "all that javascript", "we need to do that in TypeScript". The senior developers facilitate this attitude. If they would adopt Angular standards more, and not TypeScript or outdated web standards, they could reduce their code base by 70% to have a more performant and secure architecture.

As a result, the bugs in their apps are infinite.

Advice to Management

Have you and your teams learn technology thoroughly before you use it. Research the technology standards, and listen to the community if they communicate anti-patterns. Google search is an excellent learning tool.

Was this helpful?

Charles Schwab Interview Experiences