Here's what makes the test plan in the video (also linked below) so great:
- It's a video - This is the clearest way to show a change, especially for product changes.
- It goes through edge cases - This demonstrates that the code is robust and the author is thoughtful.
- It's embedded directly in the PR - This is very minor, but it improves quality of life for the reviewer as they don't need to navigate to a different website or another tab to see the test plan.
For the code review in question alongside others with great test plans:
For more resources on how to submit cleaner pull requests and go through code review more smoothly: