Received major feedback on code review
I am a software engineer intern at Meta. Today I just sent out a diff but it received lots of feedback. I really appreciate the feedback my mentor gave me and will definitely compile it into a doc so I don’t make the same mistakes again.
My concern is: will a single diff in the beginning of Week 2 hurt my chances of getting a good rating? Is it even normal for interns to get significant feedback on diffs in the first two weeks?
For more context, this is regarding a project task, as I had already finished the onboarding tasks. The code works, the test cases are plentiful, and most of the feedback is regarding code maintainability (modularization, function naming).
Discussion
(2 comments)- 12 days agoTech Lead/Manager at Meta, Pinterest, Kosei
You're overthinking this. The fact that you got so much feedback early on is actually an opportunity for you. You should rapidly incorporate the feedback and show how you're applying it. (See the corresponding lesson about Code Review from the internship course.) It is absolutely normal for interns to get lots of feedback and back-and-forth on code review.
If you got this barrage of feedback in week 10 of your internship, that's more cause for concern. But now is the perfect time to receive this and apply it.
- 0
a day agoTech Lead @ Robinhood, Meta, Course HeroIt doesn't matter if you're an intern or not - 99% of new Meta engineers get flooded in code review after they join (myself included) 🤣
This is all a part of learning and becoming a better engineer. It's actually good that you're getting the feedback as it shows your mentor cares and actually wants you to improve. Week 2 is so early that there's no way this can hurt you.
What will determine your score though is how you respond to the feedback:
- Do you address it quickly? (i.e. within a few hours, you are responding to the comments/adding patch commits)
- Do you address it gracefully? (i.e. you aren't weirdly defensive about it and are appreciative)
- Do you remember it? (i.e. you aren't making 90%+ similar mistakes again in the future)
As an intern, 80%+ of your time is available to code with, so you have the resources to do all 3 of the above.
Here's a good related thread: "How to ensure mistakes do not repeat?"
Related Course
Other Great Discussions
![Senior Software Engineer [E5] at Meta company logo](/_next/image/?url=https%3A%2F%2Ffirebasestorage.googleapis.com%2Fv0%2Fb%2Ftech-career-growth.appspot.com%2Fo%2Fcompany_logos%252Fmeta.jpeg%3Falt%3Dmedia%26token%3Da7a5bcc0-e178-4b5b-b71e-09bf6c6aefae&w=96&q=75){kind=small}
