Meta Internship Code Review

Hi Taro Community,

It is the start of Week 5 of my Meta internship. My code quality has steadily been improving ever since the second week. I have been consistently been getting less comments, and both my intern manager and peers mention that my code is getting much easier to review. Around 50% of the diffs are getting accepted on the first try, and for the other 50%, no major revisions were needed. During the most recent 1 on 1, my intern manager sent me written feedback saying I was doing excellent in all five axes. He emphasized my consistent improvement over the past few weeks.

However, I just landed a diff where the intern manager left a comment that was similar to a comment in one of my previous diffs a week ago. It was about moving duplicate code to a separate common until file. I definitely appreciate my intern manager’s kind feedback, but I feel really bad that I repeated a similar coding quality mistake that I made in the past. I have a habit of writing all feedback that I receive in a doc, but somehow I neglected to thoroughly check that doc before submitting that diff.

I know it is not great to dwell over a mistake already made, but I am feeling a bit anxious as the midpoint review will be in a few days. I really hope that this mistake will not significantly harm my midpoint review. Is there anything I should say during my next 1 on 1 (which will happen in 2 days) to help my chances? I am fully committed to learning from this mistake but hope that this incident will not significantly harm my midpoint review.

I feel very fortunate to have such a kind, thoughtful, and supportive intern manager. So far, my intern manager and I are getting along quite well. I just hope the mistake I made will not significantly harm his perception of me.