Taro Logo
0

Intern diffs are long but IM and peers don't mind

Profile picture
Software Engineering Intern at Meta2 months ago

I'm around midpoint for my internship and I've ended up having quite a few longer diffs that are difficult to split. In various courses it's mentioned that having small diffs is very important so this something I'm trying to stay conscious of but the nature of my changes makes this difficult at times. I asked my IM and peers specifically about this and they all said they don't have problems with it but I'm worried this might come up in calibration as a big negative for me despite what my peers/IM have said. To put it into perspective right now I have about 45 diffs and ~10k SLOC written so it's an average of ~220. Will this end up being an issue in PSC?

43
1

Discussion

(1 comment)
  • 1
    Profile picture
    Tech Lead @ Robinhood, Meta, Course Hero
    a month ago

    220 is on the higher end, but it's within that 250 line range I mentioned. Some diffs are indeed naturally hard to split.

    As long as all your peers are okay with it, I wouldn't worry about it. The main thing to look at is the number of revisions your diffs go through alongside comment volume (more feedback comments = more problems in the code generally).