Taro Logo
1.8K
69 Likes

3 Ways To Write Deeper, More Impactful Code Review Comments

Here are the core points from the video:

  • Humans make bad IDEs: Don't focus on leaving code review feedback on syntax issues.
  • The main question to ask yourself when doing a code review: "How would I write this pull request if I were in the author's shoes?"
    • From here, find the delta between your approach and theirs. That is a bountiful area for you to leave salient code review feedback for.
  • Observe how the more senior engineers on your team do code review, particularly why they reject revisions
    • Senior engineers will be finding deeper issues, which is part of the reason why they're senior. If you incorporate that behavior into your code review repertoire, you are well on your own way towards becoming a senior engineer.

Related resources: