Name: One Diff, One Thesis - What Every Code Review Should Be Like
Uploaded: 2022-04-09
Duration: 4 min 40 s
Description: Here's the full masterclass session on code review, which is where this clip was taken from

One Diff, One Thesis - What Every Code Review Should Be Like

[Here's the full masterclass session on code review](https://link.jointaro.com/29jyjjRiaUBZ1htQ9), which is where this clip was taken from.

Core points:
- Every commit and pull request (PR) you put out should have a singular focus. Don't just dump your entire feature into 1 massive 2,500 line PR; it's extremely difficult to review and you are robbing yourself of real technical feedback.
- A good average range for a PR is 50-250 lines of code. If it's substantially higher than 250, there's a good chance your PR is simply too big.
- Breaking up your pull requests will take more time initially (10-15 minutes), but it's completely worth it as it saves you time in the long-term. Smaller, more focused PRs get better feedback and are merged in faster.
- Having this habit alongside all the other good code review behaviors (linked below) is one of the most straightforward way to get a stellar performance review as an earlier-in-career engineer. Conversely, not following these guidelines is one of the easiest ways to have bad performance as a software engineer.

Related resources:
- [What A Test Plan Is And Why Every Code Review Needs One](https://link.jointaro.com/HFTUGFA9MyanBHQb7)
- [The Most Common Mistake Made When Authoring Code Reviews](https://link.jointaro.com/qUE9hk1MNf86NU7RA) - This covers how to attach great context to your pull requests.
- ["How can I write great code faster?"](https://link.jointaro.com/7dMeqXwrGceNM3kr6)
- [Avoid These Junior Engineer Mistakes With Code Review](https://link.jointaro.com/agkYrLH8uuCv4UcPA)

Here's the full masterclass session on code review, which is where this clip was taken from

Code review is one of the most common and powerful ways for software engineers to learn. On top of increasing code quality, it builds engineering culture within a team.