1

Should I be worried

Profile picture
Mid-Level Software Engineer [E4] at Meta13 days ago

I joined this June. Our team has two chunks, one is doing project M and the other doing project H. For the first three month, project M was my ramp up project and manager said I did well. In the mid of October, my mentor told manager that I have code quality problem, writing too fast with bugs in diff. Manager talked to me once and pointed out, which I appreciate. Then the last quarter began, I was assigned both project M and project H work, project H is very coding heavy because of the design pattern and for project M, the tl didn't give any input, I would have to basically guess in the doc, according to the previous pattern, we can present the doc, let people comment, at the same time, start to work(it's building a dashboard), but my manager insist that I need to get a signoff from the project M tl, which I previously actively ask for input, no response, after the dashboard was drafted, the tl was not satisfied and told manager, manager told me he will let other people take over this. That's part one.

Part two, the tl from project H provided detailed guideline and I raised diff in time, but the person was really busy, I can't get my diff reviewed, for a whole week, I only got one review, even though the work has a target date, but that seems not to be meaningful with the sluggish review process, I also asked other team members involved in project H to take a look at my diff, only one person responded after three days. The feedback from this tl is that he can't approve my diff fast. Then the manager think it's still my code quality issue, which I paid extra attention after last feedback, so I was really confused with what he said. The diff review process is always an issue, it was brought again and again during team meeting, but nothing was done to really solve it

The PSC is looming, good part is that I don't need to participate it since I'm TNTE. But I still sense the atmosphere has changed from manager. I thinks the work assigning has some issue as I have never worked on project H before and because of this heavy coding task, I needed extra time for it, hence having no time for project M's dashboard.

Should I be worried at this team? I am not eligible to transfer now, what should I expect next year?

104
4

Discussion

(4 comments)
  • 1
    Profile picture
    Engineer @ Robinhood
    13 days ago

    I'm going to take a shot in the dark: your diffs are likely too big. As a result:

    • It's making it harder for others to properly review
    • It's harder to have an exhaustive test plan for every diff you put up

    Break up your changes into smaller diffs (ideally at most 100 lines of non-test code changed) and try to split out codegen + boilerplate code changes into isolated diffs.

    In terms of how this will impact perf, I'd say this pushes you down to Meets Most (MM). E3/E4 perf is usually focused on coding fundamentals (speed + quality)

    I might be off though since I don't have the full context. Maybe this course can help?

    • 0
      Profile picture
      Mid-Level Software Engineer [E4] [OP]
      Meta
      13 days ago

      Thanks for reply. Do you know how is quality measured? We have team insight metrics that mostly tell how many lines I write and how fast I close a diff, but seems not much to tell the quality of a diff. The only thing I can see is number of comments by others. Also I asked other more than one time the number of revision in a diff is not counted in metric, am I correct?

    • 1
      Profile picture
      Engineer @ Robinhood
      12 days ago

      Look at a mix of:

      • Time to land (low = good)
      • Lines of code/diff (low = good)
      • Average words in diff summary + test plan (high = good)
      • Comments/diff (low = good)
  • 0
    Profile picture
    Tech Lead/Manager at Meta, Pinterest, Kosei
    12 days ago

    Jonathan's suggestions about code quality are spot on. I would strongly suggest you gain clarity on how you're doing relative to expectations and how you're trending.

    Go through the Am I At Risk For A PIP? section of the course.